Link collectors via OBJECT library so self-registration runs - #53
Merged
patryk-przybysz merged 1 commit intoAug 9, 2026
Merged
Conversation
patryk-przybysz
force-pushed
the
fix/agent-static-lib-collector-registration
branch
from
August 8, 2026 22:15
4b2f5a9 to
0ad4b15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RegisteredCollector<Derived>(src/collectors/collector.h). Since Add GoogleTest foundation and SeriesBuffer unit tests #49 moved sources intovolta_libas aSTATIClibrary andmain.ccreferences no collector symbols, the linker discards the collector translation units - the registry is empty at runtime and the agent silently collects zero metrics.volta_libas anOBJECTlibrary so all collector objects are always linked.Closes #52